Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close video encoder pipes and wait for it to finalize the video before exiting #1503

Merged
merged 2 commits into from Aug 13, 2020
Merged

Close video encoder pipes and wait for it to finalize the video before exiting #1503

merged 2 commits into from Aug 13, 2020

Commits on Aug 13, 2020

  1. Close video encoder pipes and wait for it to finalize the video befor… 

    …e exiting

See https://progress.opensuse.org/issues/68923#note-9
    @Martchus
    Martchus committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    2b217f2 View commit details
    Browse the repository at this point in the history

  2. Pass remaining frames to external video encoder as well 

    This change unifies the existing code for "flushing frames" with the code
to stop the video encoder.

Now the remaining data is also passed to the external video encoder. The
error handling has also been improved and there's a timeout of 30 seconds
for the flushing.
    @Martchus
    Martchus committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    ae542f1 View commit details
    Browse the repository at this point in the history