Improve error handling when connection to QMP socket #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martchus
commented
Aug 27, 2020
Martchus
commented
- Abort connection attempts if QEMU exits while trying to connect to avoid wasting time when the VM can not be started
- Improve consistency and readability of error and log messages
- See https://progress.opensuse.org/issues/68938
* Abort connection attempts if QEMU exits while trying to connect to avoid wasting time when the VM can not be started * Improve consistency and readability of error and log messages * See https://progress.opensuse.org/issues/68938
Codecov Report
@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
- Coverage 57.66% 57.64% -0.02%
==========================================
Files 55 55
Lines 6474 6476 +2
==========================================
Hits 3733 3733
- Misses 2741 2743 +2
Continue to review full report at Codecov.
|
okurz
approved these changes
Sep 1, 2020
Martchus
added a commit
to Martchus/os-autoinst
that referenced
this pull request
Sep 2, 2020
Follow-up of os-autoinst#1520 to fix tests like https://openqa.opensuse.org/tests/1381351 where QEMU is invoked multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.