Allow one to easily configure a build with commonly useful warnings #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This change does *not* change anything unless one adds `-DENABLE_WARNINGS` or `-DTREAT_WARNINGS_AS_ERRORS` to the CMake arguments. * At this point this is mainly intended to configure a development build with useful warnings enabled more easily. In other context (e.g. during rpm package builds) one can still configure warnings as they make sense in this context (e.g. by using certain rpm macros). * If all warnings are fixed, it would make sense to enable both settings for CI builds.
|
Btw, I leave it for later to actually fix the problems (or drop some of the warnings at least for some source files again) so we can enable them within CI runs. |
We cannot fix the warnings in this generated file and they look harmless.
Martchus
force-pushed
the
debug-segfault
branch
from
2043eff
to
37453f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DENABLE_WARNINGSor-DTREAT_WARNINGS_AS_ERRORSto the CMakearguments.
with useful warnings enabled more easily. In other context (e.g. during
rpm package builds) one can still configure warnings as they make sense
in this context (e.g. by using certain rpm macros).
for CI builds.