CI: Add automatic review checklist based on changed file paths #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One important factor for myself and apparently also other reviewers is that we keep forgetting or overlooking certain things in reviews because we review in multiple different projects and for each we need to look for different things, e.g. in openQA I can usually trust the automated test assuming that there are according tests added and code coverage is fine, for os-autoinst I would need to carefully try myself or ask for tests, for openQA test distributions I would need to look for according openQA verification jobs. With this commit pull requests introducing changes to any backend file as well as testapi.pm will receive an according review checklist so that reviewers as well as reviewees do not forget such changes need to be tested accordingly or API version changes need to be applied. Related progress issue: https://progress.opensuse.org/issues/107005
okurz
force-pushed
the
feature/review_checklist_poo107005
branch
from
b92b515
to
f3b99ad
Compare
perlpunk
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
- Coverage 76.80% 76.73% -0.08%
==========================================
Files 68 68
Lines 7088 7088
==========================================
- Hits 5444 5439 -5
- Misses 1644 1649 +5
Continue to review full report at Codecov.
|
Martchus
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One important factor for myself and apparently also other reviewers is
that we keep forgetting or overlooking certain things in reviews because
we review in multiple different projects and for each we need to look
for different things, e.g. in openQA I can usually trust the automated
test assuming that there are according tests added and code coverage is
fine, for os-autoinst I would need to carefully try myself or ask for
tests, for openQA test distributions I would need to look for according
openQA verification jobs.
With this commit pull requests introducing changes to any backend file
as well as testapi.pm will receive an according review checklist so that
reviewers as well as reviewees do not forget such changes need to be
tested accordingly or API version changes need to be applied.
Related progress issue: https://progress.opensuse.org/issues/107005