Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signatures in most of backend/ and consoles/ as possible #1986

Conversation

okurz
Copy link
Member

@okurz okurz commented Mar 8, 2022

No description provided.

@okurz okurz marked this pull request as draft March 8, 2022 21:21
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Great PR! Please pay attention to the following items before merging:

Files matching backend/**.pm:

  • Consider running manual verification tests, especially for non-qemu backends

Files matching consoles/**.pm:

  • Consider running manual verification tests on real hardware, especially for non-qemu backends

This is an automatically generated QA checklist based on modified files

@okurz

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@okurz okurz force-pushed the feature/signatures_in_most_of_backends_and_consoles branch from c5b76fe to 6c472e2 Compare April 17, 2022 13:01
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #1986 (d0a739e) into master (1f2717e) will increase coverage by 0.04%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   77.56%   77.60%   +0.04%     
==========================================
  Files          70       70              
  Lines        7274     7280       +6     
==========================================
+ Hits         5642     5650       +8     
+ Misses       1632     1630       -2     
Impacted Files Coverage Δ
consoles/sshIucvconn.pm 27.27% <0.00%> (-1.30%) ⬇️
backend/console_proxy.pm 95.00% <100.00%> (-0.24%) ⬇️
backend/qemu.pm 58.94% <100.00%> (ø)
consoles/VNC.pm 60.42% <100.00%> (+0.32%) ⬆️
consoles/amtSol.pm 14.28% <100.00%> (+1.55%) ⬆️
consoles/console.pm 91.89% <100.00%> (+0.46%) ⬆️
consoles/network_console.pm 100.00% <100.00%> (ø)
consoles/serial_screen.pm 100.00% <100.00%> (ø)
consoles/sshVirtshSUT.pm 50.00% <100.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2717e...d0a739e. Read the comment docs.

@okurz okurz force-pushed the feature/signatures_in_most_of_backends_and_consoles branch from 6c472e2 to ec1aeb8 Compare April 19, 2022 10:45
@okurz okurz marked this pull request as ready for review April 19, 2022 15:23
@okurz okurz force-pushed the feature/signatures_in_most_of_backends_and_consoles branch from bda5853 to f888a47 Compare April 19, 2022 16:53
@okurz okurz force-pushed the feature/signatures_in_most_of_backends_and_consoles branch from f888a47 to d0a739e Compare April 20, 2022 10:47
@mergify mergify bot merged commit fd12334 into os-autoinst:master Apr 21, 2022
@okurz okurz deleted the feature/signatures_in_most_of_backends_and_consoles branch April 21, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants