Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit test for set_pipe_sz() to ensure stable test coverage #2008

Merged
merged 1 commit into from Mar 29, 2022
Merged

Add explicit test for set_pipe_sz() to ensure stable test coverage #2008

merged 1 commit into from Mar 29, 2022

Conversation

Martchus
Copy link
Contributor

okurz
okurz approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve the PR but did you make sure that the coverage is now really stable? Like run count_fail_ratio sh -c 'make coverage TESTS=t/10-virtio_terminal.t | grep 100% …'?

@mergify mergify bot merged commit d1e87f2 into os-autoinst:master Mar 29, 2022
@kraih
Copy link
Member

kraih commented Mar 29, 2022

Theoretically this shouldn't work, because the caller also had flaky coverage before. But the latest coverage results would suggest that it does work anyway... so 🤷.

@Martchus Martchus deleted the coverage branch March 29, 2022 19:17
@Martchus
Copy link
Contributor Author

@okurz I'll try that command tomorrow. But if it is still not stable I'm out of ideas anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Martchus @kraih @okurz