Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary but potentially racy signalblocker log lines #2022

Merged
merged 1 commit into from
Apr 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions signalblocker.pm
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use POSIX ':signal_h';

sub new ($class, @args) {
# block signals
bmwqemu::diag('Blocking SIGCHLD and SIGTERM');
my %old_sig = %SIG;
$SIG{TERM} = 'IGNORE';
$SIG{INT} = 'IGNORE';
Expand All @@ -32,7 +31,6 @@ sub new ($class, @args) {

sub DESTROY ($self) {
# set back signal handling to default to be able to terminate properly
bmwqemu::diag('Unblocking SIGCHLD and SIGTERM');
die "Could not unblock SIGCHLD and SIGTERM\n" unless defined sigprocmask(SIG_UNBLOCK, $self->{_sigset}, undef);
%SIG = %{$self->{_old_sig}};
}
Expand Down