Fix re-connecting via VNC over WebSockets #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
* Before overriding the VNC hostname to `127.0.0.1` (to connect to `dewebsockify`), save the original hostname. * When checking whether VNC over WebSockets should be enabled, compare the configured `VIRSH_GUEST` with the saved hostname and not the overridden one. * This should fix the problems mentioned in https://progress.opensuse.org/issues/114820
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
+ Coverage 89.16% 89.17% +0.01%
==========================================
Files 165 165
Lines 14187 14194 +7
==========================================
+ Hits 12650 12658 +8
+ Misses 1537 1536 -1
Continue to review full report at Codecov.
|
perlpunk
approved these changes
Jul 29, 2022
okurz
approved these changes
Jul 30, 2022
|
We haven't tested it manually but let's see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
127.0.0.1(to connect todewebsockify), save the original hostname.configured
VIRSH_GUESTwith the saved hostname and not the overriddenone.
https://progress.opensuse.org/issues/114820