Add support for backing up disks during test #2341

mimi1vx · 2023-07-11T15:08:52Z

https://progress.opensuse.org/issues/130922

VR: http://quasar.suse.cz/tests/2962

github-actions · 2023-07-11T15:09:12Z

Great PR! Please pay attention to the following items before merging:

Files matching backend/**.pm:

Consider running manual verification tests, especially for non-qemu backends

Files matching testapi.pm:

Consider bumping the version number in OpenQA/Isotovideo/Interface.pm for changes in behaviour

This is an automatically generated QA checklist based on modified files.

okurz · 2023-07-11T15:10:42Z

s/[backuping/backing up/

backend/qemu.pm

backend/baseclass.pm

backend/qemu.pm

testapi.pm

codecov · 2023-07-12T11:13:21Z

Codecov Report

Merging #2341 (dba364a) into master (5f3132b) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head dba364a differs from pull request most recent head 510e09d. Consider uploading reports for the commit 510e09d to get more accurate results

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   95.05%   95.07%   +0.02%     
==========================================
  Files         155      155              
  Lines       15277    15340      +63     
==========================================
+ Hits        14521    14584      +63     
  Misses        756      756

Files Changed	Coverage Δ
OpenQA/Isotovideo/Interface.pm	`100.00% <ø> (ø)`
t/04-check_vars_docu.t	`100.00% <ø> (ø)`
t/23-baseclass.t	`100.00% <ø> (ø)`
t/data/tests/main.pm	`100.00% <ø> (ø)`
backend/baseclass.pm	`100.00% <100.00%> (ø)`
backend/qemu.pm	`100.00% <100.00%> (ø)`
t/03-testapi.t	`100.00% <100.00%> (ø)`
t/18-backend-qemu.t	`100.00% <100.00%> (ø)`
t/99-full-stack.t	`100.00% <100.00%> (ø)`
testapi.pm	`87.03% <100.00%> (+0.06%)`	⬆️

testapi.pm

backend/qemu.pm

testapi.pm

backend/qemu.pm

doc/memorydumps.asciidoc

doc/backend_vars.asciidoc

doc/memorydumps.asciidoc

backend/qemu.pm

doc/memorydumps.asciidoc

t/data/tests/tests/save_storage.pm

t/18-backend-qemu.t

backend/qemu.pm

Martchus · 2023-08-03T14:58:52Z

backend/qemu.pm

+            my $my_node = "$node-$fname";
+            my $bck_file = "assets_public/$my_node-$vars->{NAME}.qcow2";
+            # create disk
+            runcmd('qemu-img', 'create', '-f', 'qcow2', "$bck_file", "$size");


Suggested change

runcmd('qemu-img', 'create', '-f', 'qcow2', "$bck_file", "$size");

runcmd('qemu-img', 'create', '-f', 'qcow2', $bck_file, $size);

hmm, for $size yes but ab $bck_file are needed

Why would this variable need quotes?

backend/qemu.pm

doc/backend_vars.asciidoc

t/18-backend-qemu.t

backend/qemu.pm

doc/backend_vars.asciidoc

backend/qemu.pm

t/data/tests/tests/save_storage.pm

testapi.pm

t/99-full-stack.t

https://progress.opensuse.org/issues/130922

perlpunk · 2023-08-04T11:05:32Z

backend/qemu.pm

+            my $my_node = "$node-$fname";
+            my $bck_file = "assets_public/$my_node-$vars->{NAME}.qcow2";
+            # create disk
+            runcmd('qemu-img', 'create', '-f', 'qcow2', "$bck_file", $size);


Why does $bck_file need quotes?

filepath .. so can contain space and other awful characters...

Sure it can. But the quotes around the variable don't make any difference.
We're using perl here, not bash.

Look at what happens here:

% perl -wE' sub runcmd { my ($path) = @_; say "path: >>$path<<"; } my $arg = "some path with spaces"; runcmd($arg); runcmd("$arg");' path: >>some path with spaces<< path: >>some path with spaces<<

So in the function runcmd it will end up without quotes in any case.

If you wanted to add quotes, you would have to do qq{"$bck_file"}. But that doesn't make sense. The runcmd function will take care of it anyway. Those variables aren't passed to a shell. Otherwise we would already have a problem with existing runcmd calls.

mimi1vx marked this pull request as draft July 11, 2023 15:09

perlpunk reviewed Jul 11, 2023

View reviewed changes

backend/qemu.pm Show resolved Hide resolved

okurz requested changes Jul 11, 2023

View reviewed changes

backend/baseclass.pm Outdated Show resolved Hide resolved

backend/qemu.pm Outdated Show resolved Hide resolved

backend/qemu.pm Outdated Show resolved Hide resolved

backend/qemu.pm Outdated Show resolved Hide resolved

testapi.pm Outdated Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch from 262d48a to e257804 Compare July 11, 2023 15:17

kalikiana reviewed Jul 12, 2023

View reviewed changes

testapi.pm Show resolved Hide resolved

Martchus reviewed Jul 12, 2023

View reviewed changes

backend/qemu.pm Outdated Show resolved Hide resolved

backend/qemu.pm Outdated Show resolved Hide resolved

backend/qemu.pm Outdated Show resolved Hide resolved

testapi.pm Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch 5 times, most recently from 8b74252 to 18b8304 Compare July 18, 2023 11:46

kalikiana reviewed Jul 18, 2023

View reviewed changes

backend/qemu.pm Outdated Show resolved Hide resolved

okurz requested changes Jul 18, 2023

View reviewed changes

kalikiana reviewed Jul 18, 2023

View reviewed changes

doc/memorydumps.asciidoc Outdated Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch 2 times, most recently from 64b49b3 to 2916b8d Compare July 19, 2023 09:36

kalikiana reviewed Jul 19, 2023

View reviewed changes

backend/qemu.pm Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch 2 times, most recently from 1201cd7 to aabe020 Compare July 20, 2023 08:44

Martchus reviewed Jul 20, 2023

View reviewed changes

doc/memorydumps.asciidoc Outdated Show resolved Hide resolved

doc/memorydumps.asciidoc Outdated Show resolved Hide resolved

doc/memorydumps.asciidoc Outdated Show resolved Hide resolved

t/data/tests/tests/save_storage.pm Outdated Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch 3 times, most recently from aae6731 to fd43775 Compare August 3, 2023 13:38

mimi1vx requested a review from okurz August 3, 2023 13:39

mimi1vx marked this pull request as ready for review August 3, 2023 13:39

mimi1vx changed the title ~~Add support for backuping disks during test~~ Add support for backing up disks during test Aug 3, 2023

mimi1vx force-pushed the backup_drive branch from fd43775 to df933d9 Compare August 3, 2023 14:07

mimi1vx force-pushed the backup_drive branch from df933d9 to dba364a Compare August 3, 2023 14:36

Martchus requested changes Aug 3, 2023

View reviewed changes

mimi1vx force-pushed the backup_drive branch 2 times, most recently from 41bc7e5 to 058d3ce Compare August 3, 2023 16:06

mimi1vx requested a review from Martchus August 3, 2023 16:07

okurz requested changes Aug 3, 2023

View reviewed changes

kalikiana reviewed Aug 4, 2023

View reviewed changes

t/99-full-stack.t Outdated Show resolved Hide resolved

mimi1vx force-pushed the backup_drive branch from 058d3ce to 96aba52 Compare August 4, 2023 07:45

Martchus approved these changes Aug 4, 2023

View reviewed changes

mimi1vx added 5 commits August 4, 2023 10:05

Add support for saving storage during test

5be1c74

https://progress.opensuse.org/issues/130922

Document save_storage and 'SAVE_STORAGE_TIMEOUT'

ad2644f

Add 'NAME' to QEMU backend blocklist in check_vars_docu

e7be785

Add full-stack test for save_storage

d140839

Add unit test for save_storage

510e09d

mimi1vx force-pushed the backup_drive branch from 96aba52 to 510e09d Compare August 4, 2023 08:06

mimi1vx requested a review from okurz August 4, 2023 08:07

okurz approved these changes Aug 4, 2023

View reviewed changes

mergify bot merged commit a00cbb0 into os-autoinst:master Aug 4, 2023
15 checks passed

perlpunk reviewed Aug 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for backing up disks during test #2341

Add support for backing up disks during test #2341

mimi1vx commented Jul 11, 2023 •

edited

github-actions bot commented Jul 11, 2023

okurz commented Jul 11, 2023

codecov bot commented Jul 12, 2023 •

edited

Martchus Aug 3, 2023

mimi1vx Aug 3, 2023

perlpunk Aug 3, 2023

perlpunk Aug 4, 2023

mimi1vx Aug 4, 2023

perlpunk Aug 4, 2023

perlpunk Aug 4, 2023 •

edited

	runcmd('qemu-img', 'create', '-f', 'qcow2', "$bck_file", "$size");
	runcmd('qemu-img', 'create', '-f', 'qcow2', $bck_file, $size);

Add support for backing up disks during test #2341

Add support for backing up disks during test #2341

Conversation

mimi1vx commented Jul 11, 2023 • edited

github-actions bot commented Jul 11, 2023

okurz commented Jul 11, 2023

codecov bot commented Jul 12, 2023 • edited

Codecov Report

Martchus Aug 3, 2023

Choose a reason for hiding this comment

mimi1vx Aug 3, 2023

Choose a reason for hiding this comment

perlpunk Aug 3, 2023

Choose a reason for hiding this comment

perlpunk Aug 4, 2023

Choose a reason for hiding this comment

mimi1vx Aug 4, 2023

Choose a reason for hiding this comment

perlpunk Aug 4, 2023

Choose a reason for hiding this comment

perlpunk Aug 4, 2023 • edited

Choose a reason for hiding this comment

mimi1vx commented Jul 11, 2023 •

edited

codecov bot commented Jul 12, 2023 •

edited

perlpunk Aug 4, 2023 •

edited