New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-machine setup script #2347
Add multi-machine setup script #2347
Conversation
1f7fccd
to
9bd2d9d
Compare
Related progress issue: https://progress.opensuse.org/issues/133025
9bd2d9d
to
9cca1aa
Compare
Added commit "Include os-autoinst-setup-multi-machine in doc+package" |
afb76d3
to
228c7a0
Compare
I don't understand
anyone has an idea? |
228c7a0
to
55e0554
Compare
Maybe that new script gets pulled into the main package as well via that macro: https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#%perl_gen_filelist I found the use of this macro very confusing/unintuitive. So if it goes in the way I suggest to simply remove the use of |
ed441a8
to
11d9834
Compare
Ok, for now I just removed the explicit mention of the file |
But then it will end up in the wrong package. |
Well, I wouldn't care. It's just a simple shell script :) EDIT: A better explanation is: os-autoinst-setup-multi-machine can actually handle to install os-autoinst-openvswitch if it is not installed yet and also the setup script does not have additional dependencies so the script should be in the main package |
Observed jobs on w23 still not working as in https://openqa.opensuse.org/tests/3473166#step/firewalld_policy_objects/138 when tap devices were still not in the right zone. Added two commits
|
dd7aab0
to
a900bef
Compare
action="\$1" | ||
bridge="\$2" | ||
ovs-vsctl set bridge \$bridge stp_enable=true | ||
# TODO add entries according to your network topology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this TODO telling me? Do we need to add things here? Are we expecting users to edit the script before using it? If so, make it fail, so they know to edit it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the admin reading this needs to patch up the script afterwards. If it would fail then wicked would likely ignore the failure anyway.
Also see:
Related progress issue: https://progress.opensuse.org/issues/133025