Disable SVIRT_WORKER_CACHE by default #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
This feature is a nice optimization but has the caveat mentioned in the documentation and might also otherwise behave slightly different leading to issues like https://progress.opensuse.org/issues/138746. So it is likely best to only enable it in cases when it is safe to use.
Martchus
force-pushed
the
svirt-caching
branch
from
da4e998
to
292698d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2401 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 155 155
Lines 15430 15431 +1
=======================================
+ Hits 14679 14680 +1
Misses 751 751 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is a nice optimization but has the caveat mentioned in the documentation and might also otherwise behave slightly different leading to issues like https://progress.opensuse.org/issues/138746. So it is likely best to only enable it in cases when it is safe to use.