Add FIDO2 support for qemu #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
qemu support is on the way https://bugzilla.suse.com/show_bug.cgi?id=1217520 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
==========================================
+ Coverage 95.12% 95.19% +0.06%
==========================================
Files 155 156 +1
Lines 15443 15704 +261
==========================================
+ Hits 14690 14949 +259
- Misses 753 755 +2 ☔ View full report in Codecov by Sentry. |
okurz
reviewed
Dec 22, 2023
Martchus
approved these changes
Jan 2, 2024
kalikiana
reviewed
Jan 2, 2024
Introduce generic FIDO2 variable that indicates that tests should use a hardware FIDO2 token. In the qemu backend that means adding the canokey device.
Martchus
approved these changes
Jan 15, 2024
okurz
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce generic FIDO2 variable that indicates that tests should use a hardware FIDO2 token. In the qemu backend that means adding the canokey device.