Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script_run: base serial buffer size on command length #2429

Merged
merged 1 commit into from
Jan 13, 2024

Commits on Jan 11, 2024

  1. script_run: base serial buffer size on command length

    If you use script_run at a serial console to run a command more
    than 4096 characters long, the wait_serial that waits until the
    whole command has made it across the serial connection will
    fail, because it uses the default buffer size (4096), so it
    will never see the full command. This means there'll be a 90
    second timeout before the command is actually run, and a red
    frame in the results.
    
    This solves the problem by always sizing the buffer to the length
    of the command, plus 128 extra bytes (for the marker string, and
    some more for safety).
    
    Issue: https://progress.opensuse.org/issues/153304
    
    Signed-off-by: Adam Williamson <awilliam@redhat.com>
    AdamWill committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    2542836 View commit details
    Browse the repository at this point in the history