qemu: Set proper default on s390x #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Martchus
requested changes
Apr 17, 2024
okurz
force-pushed
the
feature/s390x_qemu
branch
2 times, most recently
from
7401f7e
to
53f5509
Compare
Martchus
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
All points I mentioned in my previous review have been addressed and the code looks good - so now only tests need to be adapted. Looks like tests are only failing due to Codecov. It is currently also failing in the openQA repo so probably a general problem right now.
'vga' seems to be not supported on s390x. Related progress issue: https://progress.opensuse.org/issues/158985
okurz
force-pushed
the
feature/s390x_qemu
branch
from
53f5509
to
15d6df1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 149 149
Lines 15866 15875 +9
=======================================
+ Hits 15142 15151 +9
Misses 724 724 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'vga' seems to be not supported on s390x.
Related progress issue: https://progress.opensuse.org/issues/158985