Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testapi parse_junit_log #413

Closed
wants to merge 1 commit into from
Closed

Fix testapi parse_junit_log #413

wants to merge 1 commit into from

Conversation

jtzhao
Copy link
Contributor

@jtzhao jtzhao commented Feb 3, 2016

parse_junit_log uses upload_logs to upload junit files, but forgets to add current test name as a prefix to the file name, causing it fails to open the junit file.
issue: https://progress.opensuse.org/issues/10552

parse_junit_log uses upload_logs to upload junit files, but forgets to add current test name as a prefix to the file name, causing it fails to open the junit file.
@nilxam
Copy link
Member

nilxam commented Feb 3, 2016

hmm...you already knew the junit file path, is it possible you can just use it instead of open the junit file from /ulogs, and uploading the junit file in the end of run()?

@aaannz
Copy link
Contributor

aaannz commented Feb 3, 2016

Well until it is uploaded, the file is stored at SUT. So we need to upload it to get it to os-autoinst. But since upload_logs use assert_script_run we don't have to check it's return value. So I propose to further change upload_logs subroutine to return the new name. Or to return full path to the uploaded file.
So we will then use:

$file = upload_logs($file);

Upside is if we choose to change naming again we don't need to do that anywhere else.

@nilxam
Copy link
Member

nilxam commented Feb 3, 2016

oh, yeah, you're right, it did parsing out of SUT.

@nilxam
Copy link
Member

nilxam commented Feb 3, 2016

and I like the idea 👍

@jtzhao
Copy link
Contributor Author

jtzhao commented Feb 3, 2016

I agree. I can submit another to make upload_logs to return the uploaded file path.

@coolo
Copy link
Contributor

coolo commented Feb 3, 2016

yeah, do that please

@jtzhao jtzhao closed this Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants