add an option to upload_logs to avoid dying on failure #490
Conversation
|
I'm testing this right now. What's that you say? Test first then submit a PR? Nahhh, that doesn't sound like fun... |
|
welp, looks like it works: compare https://openqa.fedoraproject.org/tests/14834 (sad! missing log files! post fail hook died half way through when the weird behaviour on the very last log file is just because I made a stupid typo when editing that file's |
|
yeah, but I don't like the ,1 - wherever we have this in a API the test writers tend to just copy&paste this magic number without knowing what it does (see type_string and send_key ). Better have a named parameter as we added for type_string and as discussed in os-autoinst/os-autoinst-distri-opensuse#1069 |
|
hehe, I can believe it =) OK, will update that soon. thanks. |
AdamWill
force-pushed
the
upload-logs-failok
branch
from
2529f5b
to
8022d93
Compare
|
How does that look? |
in Fedora we use upload_logs a lot in post-fail hooks, and in some cases the file may not exist. For instance, anaconda creates lots of log files, some of which may not exist in some circumstances. We would like to just be able to try and upload them all but not have the post-fail hook die if any of them does not exist, instead of having to test for each file's existence before uploading it, or have a bunch of conditionals that magically know which log files will exist in which state.
AdamWill
force-pushed
the
upload-logs-failok
branch
from
8022d93
to
cbe86de
Compare
|
oh perltidy, why must you. |
|
do your friends know what kind of perl hacker you became? :) |
|
@coolo you must NEVER TELL actually i just ripped that off from |
in Fedora we use upload_logs a lot in post-fail hooks, and in
some cases the file may not exist. For instance, anaconda
creates lots of log files, some of which may not exist in some
circumstances. We would like to just be able to try and upload
them all but not have the post-fail hook die if any of them
does not exist, instead of having to test for each file's
existence before uploading it, or have a bunch of conditionals
that magically know which log files will exist in which state.