Get output from SSH commands #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| # In list context returns pair ($stdout, $stderr). In void (and scalar) | ||
| # context just logs stdout and stderr, returns nothing. | ||
| sub get_ssh_outputs { | ||
| my $chan = shift; |
There was a problem hiding this comment.
please don't use shift for parameters. Look around in this file
|
I'm a bit puzzled by the plural. I consider stderr and stdout part of the one output, it's just two channels of it. |
And remove Xen HVM emulator setup which is not needed.
|
Sub is now in singular. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove Xen HVM emulator setup which is not needed.