Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the VM more reliable #541

Merged
merged 1 commit into from Jul 18, 2016
Merged

Stop the VM more reliable #541

merged 1 commit into from Jul 18, 2016

Conversation

coolo
Copy link
Contributor

@coolo coolo commented Jul 18, 2016

If isotovideo is TERMinated, we need to make sure to exit the loop
no matter when it happened - and stop the VM at the end of it

https://progress.opensuse.org/issues/12566

If isotovideo is TERMinated, we need to make sure to exit the loop
no matter when it happened - and stop the VM at the end of it

https://progress.opensuse.org/issues/12566
@okurz
Copy link
Member

okurz commented Jul 18, 2016

LGTM, wouldn't mind tests as part of os-autoinst tests, though. If @AdamWill can do, I guess you can, too ;-)

@coolo
Copy link
Contributor Author

coolo commented Jul 18, 2016

I wouldn't mind them either. Perhaps you know someone in QA...

@coolo coolo merged commit 702284b into master Jul 18, 2016
@coolo coolo deleted the kill_the_vm_at_exit branch July 18, 2016 12:20
@AdamWill
Copy link
Contributor

I'm on vacation for the next week and a half, FWIW - I may find a couple of hours to update our staging deployment to whatever @coolo has cooked up lately some day, but no promises. Our production is still running the Before Coolo code at this point.

@sysrich
Copy link
Member

sysrich commented Jul 21, 2016

BC - Before Coolo..

On 21 Jul 2016 4:04 p.m., "Adam Williamson" notifications@github.com
wrote:

I'm on vacation for the next week and a half, FWIW - I may find a couple
of hours to update our staging deployment to whatever @coolo
https://github.com/coolo has cooked up lately some day, but no
promises. Our production is still running the Before Coolo code at this
point.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#541 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJGoAqxdHzjn-6qZpHnHFzzLgThOwNuks5qX3x7gaJpZM4JOnd-
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants