Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure last received frame is passed on after some delay #801

Merged

Conversation

StefanBruens
Copy link
Contributor

The needle matching might work on outdated frames if the last changes
where below the threshold. Implement a leaky bucket scheme for the
threshold so all frames but exact repetitions are candidates for updates.

For the video, the error might even have had accumulated, e.g. by a series
of frames with a similarity more than 50.

Fix for poo#15302

Signed-off-by: Stefan Brüns stefan.bruens@rwth-aachen.de

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 51.426% when pulling 569ea6a on StefanBruens:force_framebuffer_update_after_delay into 60fac26 on os-autoinst:master.

@StefanBruens StefanBruens force-pushed the force_framebuffer_update_after_delay branch from 569ea6a to f6c6983 Compare May 25, 2017 21:53
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 51.426% when pulling f6c6983 on StefanBruens:force_framebuffer_update_after_delay into 60fac26 on os-autoinst:master.

@coolo
Copy link
Contributor

coolo commented May 26, 2017

rebase onto your video changes

The needle matching might work on outdated frames if the last changes
where below the threshold. Implement a leaky bucket scheme for the
threshold so all frames but exact repetitions are candidates for updates.

For the video, the error might even have had accumulated, e.g. by a series
of frames with a similarity more than 50.

Fix for poo#19302

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
@StefanBruens StefanBruens force-pushed the force_framebuffer_update_after_delay branch from f6c6983 to a76ed48 Compare May 26, 2017 08:46
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 51.4% when pulling a76ed48 on StefanBruens:force_framebuffer_update_after_delay into afaaab4 on os-autoinst:master.

@coolo coolo merged commit 52e3055 into os-autoinst:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants