[WIP] Improve User-feedback for VNC sockets is not existing #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ipmi and s390x sometimes jobs gets incomplete or fail without a module This PR is meant to improve user feedback by showing a record_info box with a proper error message see related tickets: https://progress.opensuse.org/issues/20022 https://progress.opensuse.org/issues/23650
okurz
reviewed
Oct 7, 2017
| @@ -878,7 +880,11 @@ sub _receive_message { | |||
| my $self = shift; | |||
|
|
|||
| my $socket = $self->socket; | |||
| $socket or die 'socket does not exist. Probably your backend instance could not start or died.'; | |||
| #$socket or die 'socket does not exist. Probably your backend instance could not start or died.'; | |||
There was a problem hiding this comment.
should be deleted then but I would like to keep the text in the exception error message. We should give that hint to the test writer that probably we should not have run into that step at all, i.e. test code need to be changed or the SUT does not respond. And not "there is no socket because something is wrong in the backend"
There was a problem hiding this comment.
It's done below, so I'll create another PR based on this one with commented code removed,
rwx788
pushed a commit
to rwx788/os-autoinst
that referenced
this pull request
Oct 9, 2017
[PR#862](os-autoinst#862) review comment fix.
|
superseded by 864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ipmi and s390x sometimes jobs gets incomplete or fail without a module
This PR is meant to improve user feedback by showing a record_info box with a proper
error message
see related tickets:
https://progress.opensuse.org/issues/20022
https://progress.opensuse.org/issues/23650