Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Introduce a slim pvm backend using ssh #909

Closed
wants to merge 1 commit into from

Conversation

coolo
Copy link
Contributor

@coolo coolo commented Jan 16, 2018

This requires ssh access to a novalink installation, but currently does
little around it.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


# the spvm backend will only support the basics, but generally through
# ssh to a novalink installation (so you only need ssh and terminal on worker)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POD?

This requires ssh access to a novalink installation, but currently does
little around it.
my $ssh = $testapi::distri->add_console('novalink-ssh', 'ssh-xterm', {
hostname => get_required_var('NOVALINK_HOSTNAME'),
password => get_required_var('NOVALINK_PASSWORD'),
username => get_var('NOVALINK_USERNAME', 'root')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You use NOVALINK_USERNAME but NOVALINK_USER in run_cmd.

@asdil12
Copy link
Member

asdil12 commented Jun 21, 2018

@coolo
I rebased your patch and corrected the NOVALINK_USER to NOVALINK_USERNAME:
909.patch

Could you push this to your branch?

@coolo
Copy link
Contributor Author

coolo commented Jun 21, 2018

No, just pick my commits and make your own PR

@coolo coolo closed this Jun 21, 2018
@asdil12
Copy link
Member

asdil12 commented Jun 21, 2018

--> #979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants