Improve error handling #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a trap call to make sure we always get a message on stderr in which script and which line the error happened. We sometimes get a non-zero exit code but don't know where the error happened. I didn't add the trap to openqa-investigate, because practically the whole code is wrapped in a conditional (investigate || error_count++), and -e (and trap) is disabled by that. Also turned several echos into echoerr as it was supposed to land in our log, not in stdout. Issue: https://progress.opensuse.org/issues/99519
perlpunk
force-pushed
the
error-handling
branch
from
dfc58b6
to
9f301d8
Compare
okurz
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trap call to make sure we always get a message on stderr in which script
and which line the error happened. We sometimes get a non-zero exit code but
don't know where the error happened.
I didn't add the trap to openqa-investigate, because practically the whole
code is wrapped in a conditional (
investigate || error_count++), and-e(and trap) is disabled by that.Also turned several echos into echoerr as it was supposed to land in our
log, not in stdout.
Issue: https://progress.opensuse.org/issues/99519