Fix postponing the investigation #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure the `main()` function of `openqa-investigate` actually passes the
return code of the `investigate()` call
* Only returns the return code of the last `investigate()` call but
that should be ok since we're only investigating one job at a time
in `openqa-label-known-issues-and-investigate-hook`
* Add `set -e` to `openqa-label-known-issues-and-investigate-hook` for
consistent behavior regardless whether the script is called via shebang
or not
* Tested against my local instance to see whether
`openqa-label-known-issues` and
`openqa-label-known-issues-and-investigate-hook` will actually return 142
* See https://progress.opensuse.org/issues/95783
okurz
reviewed
Jul 13, 2022
okurz
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main()function ofopenqa-investigateactually passes thereturn code of the
investigate()callinvestigate()call butthat should be ok since we're only investigating one job at a time
in
openqa-label-known-issues-and-investigate-hookset -etoopenqa-label-known-issues-and-investigate-hookforconsistent behavior regardless whether the script is called via shebang
or not
openqa-label-known-issuesandopenqa-label-known-issues-and-investigate-hookwill actually return 142