Fix openqa-investigate exception handling #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by os-autoinst@060bbeb By making openqa-investigate operating on only a single id the || = rc=$? was removed. As a result, failing commands inside the investigate() function would return on error, so query_dependency_data_or_postpone() and sync_via_investigation_comment() would just result in an exit 255. So we didn't get any investigate jobs since this change. Somehow that part doesn't seem to be tested well. Also it's a bit hard to follow the script's logic here because we transport results with certain exit codes. I'll check if I can improve the test in my current PR for posting comments. Issue: https://progress.opensuse.org/issues/98862
perlpunk
force-pushed
the
fix-investigate-exception-handling
branch
from
c308fa8
to
89669be
Compare
okurz
approved these changes
Jan 23, 2023
Martchus
requested changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by 060bbeb
By making openqa-investigate operating on only a single id the
was removed. As a result, failing commands inside the investigate() function would return on error, so
query_dependency_data_or_postpone()andsync_via_investigation_comment()would just result in an exit 255.So we didn't get any investigate jobs since this change.
Somehow that part doesn't seem to be tested well. Also it's a bit hard to follow the script's logic here because we transport results with certain exit codes.
I'll check if I can improve the test in my current PR for posting comments.
Issue: https://progress.opensuse.org/issues/98862