Fix handling of case when no last good tests were found #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we return 1, then the script will be aborted, and then after trigger_jobs() the finalize_investigation_comment won't be executed anymore, leaving an unfinished comment "Starting investigation for job ...". I guess previously it was ok because we only wrote a simple comment, and the "Starting investigation" comment feature was added later. Related issue: https://progress.opensuse.org/issues/126527
mimi1vx
approved these changes
Mar 27, 2023
baierjan
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we return 1, then the script will be aborted, and then after trigger_jobs() the finalize_investigation_comment won't be executed anymore, leaving an unfinished comment "Starting investigation for job ...".
I guess previously it was ok because we only wrote a simple comment, and the "Starting investigation" comment feature was added later.
Related issue: https://progress.opensuse.org/issues/126527