-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify product issues #223
Conversation
02e83ce
to
d727b23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this makes generally sense.
d727b23
to
c992c51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
3f645cf
to
e543a1a
Compare
I updated the screenshot with a new comment I just created on osd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Bash code it looks quite clean. I only have a few remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain in more detail why you wait for the retry-comment and extend that instead of it's open comment? If you wanted to reduce the amount of comments and have found a good way to edit existing comments how about always updating the existing initial comment instead?
openqa-investigate
Outdated
is-product-issue "$origin_job_id" || return $? | ||
|
||
if "$product_issue"; then | ||
comment+="."$'\n'"Test(s) with last good build pass, likely a product issue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the past tense and the actual result for the tests job, I would use the same here, i.e. "passed" or "soft-failed". As alternative use "ok", as we also use within openQA where we define "ok" as "passed or soft-failed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Jobs including the last good build are ok, likely a product issue"
I don't understand that sentence at all. Can you rephrase? What waiting do you mean?
Yes, that would be possible. |
Sorry. I meant: Please explain why you add a message to the comment from the "retry" investigation job instead of creating a new comment with just your information about potential product regression |
Because I'm doing that at the same time anyway. Posting two different comments didn't even occur to me. At the time I know that the simple retry test failed, I also investigate the other investigation tests, and then I post a comment with that combined information. I have this information at the same time. It wouldn't make sense to me to just split these two sentences into two comments. We also don't split the first investigation test list into four separate comments. Maybe we can clarify this tomorrow in a chat. |
Use the retry job to fetch the results of the other investigate jobs by parsing the investigation comment. Issues: * https://progress.opensuse.org/issues/126527 * https://progress.opensuse.org/issues/109920
Spike solution which uses the retry job to fetch the results of the other investigate jobs by parsing the investigation comment.
Use the retry job to fetch the results of the other investigate jobs by
parsing the investigation comment.
Issues:
Demo:
![investigate-identify-product-issues](https://private-user-images.githubusercontent.com/688850/249788031-5bf11e85-a89a-4406-b7c2-eb55c2db11b4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4NjA5MDgsIm5iZiI6MTcyMzg2MDYwOCwicGF0aCI6Ii82ODg4NTAvMjQ5Nzg4MDMxLTViZjExZTg1LWE4OWEtNDQwNi1iN2MyLWViNTVjMmRiMTFiNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxN1QwMjEwMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jM2YxOGU3MDZmMWIyNDhjNDc2MmE3OGJmZDllMzdiN2QwYmFkMzYwNmY1ODEyMTEzMWY5NDYwODc3NTRmNzhkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VhO2J7XPTRuhn1NXolIyWLZpURWRcUCy1UQ-Y38aml8)