Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify product issues #223

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Mar 29, 2023

Spike solution which uses the retry job to fetch the results of the other investigate jobs by parsing the investigation comment.

Use the retry job to fetch the results of the other investigate jobs by
parsing the investigation comment.

Issues:

Demo:
investigate-identify-product-issues

@perlpunk perlpunk force-pushed the product-issues branch 2 times, most recently from 02e83ce to d727b23 Compare March 29, 2023 15:31
@perlpunk perlpunk requested review from okurz and Martchus March 31, 2023 10:52
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this makes generally sense.

openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@perlpunk perlpunk force-pushed the product-issues branch 3 times, most recently from 3f645cf to e543a1a Compare June 29, 2023 13:20
@perlpunk perlpunk marked this pull request as ready for review June 29, 2023 13:26
@perlpunk perlpunk changed the title Draft - Identify product issues Identify product issues Jun 29, 2023
@perlpunk
Copy link
Contributor Author

I updated the screenshot with a new comment I just created on osd.

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Bash code it looks quite clean. I only have a few remarks.

openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
openqa-investigate Outdated Show resolved Hide resolved
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in more detail why you wait for the retry-comment and extend that instead of it's open comment? If you wanted to reduce the amount of comments and have found a good way to edit existing comments how about always updating the existing initial comment instead?

is-product-issue "$origin_job_id" || return $?

if "$product_issue"; then
comment+="."$'\n'"Test(s) with last good build pass, likely a product issue"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the past tense and the actual result for the tests job, I would use the same here, i.e. "passed" or "soft-failed". As alternative use "ok", as we also use within openQA where we define "ok" as "passed or soft-failed"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Jobs including the last good build are ok, likely a product issue"

@perlpunk
Copy link
Contributor Author

perlpunk commented Jul 3, 2023

Can you explain in more detail why you wait for the retry-comment and extend that instead of it's open comment?

I don't understand that sentence at all. Can you rephrase? What waiting do you mean?
What do you mean with "it's open comment"?

If you wanted to reduce the amount of comments and have found a good way to edit existing comments how about always updating the existing initial comment instead?

Yes, that would be possible.

@okurz
Copy link
Member

okurz commented Jul 3, 2023

Can you explain in more detail why you wait for the retry-comment and extend that instead of it's open comment?

I don't understand that sentence at all. Can you rephrase? What waiting do you mean? What do you mean with "it's open comment"?

Sorry. I meant: Please explain why you add a message to the comment from the "retry" investigation job instead of creating a new comment with just your information about potential product regression

@perlpunk
Copy link
Contributor Author

perlpunk commented Jul 3, 2023

Sorry. I meant: Please explain why you add a message to the comment from the "retry" investigation job instead of creating a new comment with just your information about potential product regression

Because I'm doing that at the same time anyway. Posting two different comments didn't even occur to me.

At the time I know that the simple retry test failed, I also investigate the other investigation tests, and then I post a comment with that combined information. I have this information at the same time. It wouldn't make sense to me to just split these two sentences into two comments.

We also don't split the first investigation test list into four separate comments.

Maybe we can clarify this tomorrow in a chat.

Use the retry job to fetch the results of the other investigate jobs by
parsing the investigation comment.

Issues:
* https://progress.opensuse.org/issues/126527
* https://progress.opensuse.org/issues/109920
@mergify mergify bot merged commit 27224b4 into os-autoinst:master Jul 4, 2023
4 checks passed
@perlpunk perlpunk deleted the product-issues branch July 4, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants