Fix warnings about empty variables #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw warnings in the logs:
/opt/os-autoinst-scripts/openqa-investigate: line 239: : command not found
/opt/os-autoinst-scripts/openqa-investigate: line 241: : command not found
By testing if the variables have content this can be fixed.
Not sure how I would make such warnings fatal in our tests.
Issue: https://progress.opensuse.org/issues/132272
Martchus
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw warnings in the logs:
By testing if the variables have content this can be fixed. Not sure how I would make such warnings fatal in our tests.
Issue: https://progress.opensuse.org/issues/132272