Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow investigation to schedule modules regardless PUBLISH_ #299

Merged
merged 1 commit into from Mar 18, 2024

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Mar 11, 2024

Due to conditions in main_common PUBLISH_* variable cant be empty. Set to None to allow the scheduling.

https://progress.opensuse.org/issues/156394

@b10n1k b10n1k requested review from perlpunk and okurz March 11, 2024 07:55
@b10n1k b10n1k force-pushed the investigate_publish_workaround branch from f59d553 to 97b883d Compare March 11, 2024 07:56
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://progress.opensuse.org/issues/156394#note-14
Jobs would still fail in the same way in before. And how does os-autoinst and openQA handle the jobs trying to publish a non-existant asset "none"?

@b10n1k
Copy link
Contributor Author

b10n1k commented Mar 11, 2024

According to https://progress.opensuse.org/issues/156394#note-14 Jobs would still fail in the same way in before. And how does os-autoinst and openQA handle the jobs trying to publish a non-existant asset "none"?

I am looking at the second part now. Which maybe it would be good idea to do first

@perlpunk
Copy link
Contributor

According to https://progress.opensuse.org/issues/156394#note-14 Jobs would still fail in the same way in before.

That's actually a good thing. With that I meant that it ran the whole schedule, so the investigation job could reproduce the original failure.

But I guess we should set this to not-ready until changes are done on the openQA side.

openqa-investigate Outdated Show resolved Hide resolved
Due to conditions in main_common PUBLISH_* variable cant be empty. Set to
`None` to allow the scheduling.

https://progress.opensuse.org/issues/156394
Signed-off-by: ybonatakis <ybonatakis@suse.com>
@b10n1k b10n1k force-pushed the investigate_publish_workaround branch from 97b883d to 9e196eb Compare March 14, 2024 11:33
@okurz
Copy link
Member

okurz commented Mar 14, 2024

@b10n1k can you reply to #299 (comment) please?

@b10n1k
Copy link
Contributor Author

b10n1k commented Mar 14, 2024

According to https://progress.opensuse.org/issues/156394#note-14 Jobs would still fail in the same way in before.

That's actually a good thing. With that I meant that it ran the whole schedule, so the investigation job could reproduce the original failure.

But I guess we should set this to not-ready until changes are done on the openQA side.

Sorry missing to reply earlier. However we were looking on this with @kalikiana . I remember running a job (with an older commit of os-autoinst os-autoinst/os-autoinst#2470) and observe to observe the behavior. the job finishes without uploading hdd and without any further problem. If there is something else to be done in openQA i havent seen it. openQA seems to handle the rest properly without any change.

@mergify mergify bot merged commit 403ec8f into os-autoinst:master Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants