Add racktables machine reachability check #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksinger
force-pushed
the
add_racktables
branch
from
01bf0e0
to
a66e346
Compare
asdil12
reviewed
Apr 15, 2024
nicksinger
force-pushed
the
add_racktables
branch
from
a66e346
to
cf460fb
Compare
nicksinger
force-pushed
the
add_racktables
branch
from
cf460fb
to
c23e503
Compare
Martchus
reviewed
Apr 15, 2024
racktables/racktables.py
Outdated
| req = self.s.get(join(self.url, "index.php"), params="&".join("%s=%s" % (k,v) for k,v in search_payload.items())) | ||
| soup = BeautifulSoup(req.text, 'html.parser') | ||
| result_table = soup.find("table", {"class": "cooltable"}) | ||
| result_objs = result_table.find_all("tr", lambda tag: tag != None) #racktables does not use table-heads so we have to filter the header out (it has absolutely no attributes) |
There was a problem hiding this comment.
Suggested change
| result_objs = result_table.find_all("tr", lambda tag: tag != None) #racktables does not use table-heads so we have to filter the header out (it has absolutely no attributes) | |
| result_objs = result_table.find_all("tr", lambda tag: tag != None) # Racktables does not use table-heads so we have to filter the header out (it has absolutely no attributes) |
asdil12
reviewed
Apr 15, 2024
asdil12
reviewed
Apr 15, 2024
asdil12
reviewed
Apr 15, 2024
|
Could you maybe indent the python scripts also by 4. (Or using tabs - I would totally approve that as well :P) |
nicksinger
force-pushed
the
add_racktables
branch
from
c23e503
to
b1a6ef5
Compare
nicksinger
force-pushed
the
add_racktables
branch
from
b1a6ef5
to
9fa9386
Compare
|
So all the changes you requested are in b1a6ef5 but the current version of both |
Martchus
approved these changes
Apr 15, 2024
okurz
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://progress.opensuse.org/issues/158907