Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runjq wrapper to see potential errors in API outputs #329

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Use runjq wrapper to see potential errors in API outputs #329

merged 1 commit into from
Jul 22, 2024

Conversation

baierjan
Copy link
Member

perlpunk
perlpunk reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this we need a change on the gitlab side as well.
There we only download the script instead of cloning the repo, so there is no _common file

@baierjan
Copy link
Member Author

I think for this we need a change on the gitlab side as well. There we only download the script instead of cloning the repo, so there is no _common file

Yes, that's correct. That change is already done; I just reused the framework which was added by Nick. The pipeline is cloning this whole repo.

@perlpunk
Copy link
Contributor

Yes, that's correct. That change is already done; I just reused the framework which was added by Nick. The pipeline is cloning this whole repo.

Ok, I didn't see any change in the script-ci repo...
I guess it's a bit confusing that the pipelin clones the repo and then still downloads the script with curl...

@baierjan
Copy link
Member Author

Ok, I didn't see any change in the script-ci repo... I guess it's a bit confusing that the pipelin clones the repo and then still downloads the script with curl...

All changes are in the GUI (additional variables in the pipeline schedule); it could be, but I guess it was easier to support both modes in this way 🤷🏻

@mergify mergify bot merged commit 22e0a7d into master Jul 22, 2024
6 checks passed
@mergify mergify bot deleted the use_wrapper branch July 22, 2024 14:36
baierjan added a commit that referenced this pull request Jul 22, 2024
@baierjan
Disable tracing to limit the output
6836df7 
Calling the wrappers with #329 could be quite noisy with all the debug
information on as the whole API outputs gets reprinted in the terminal.
Disable the debug info so the logs are visible in the Gitlab UI.

Reference: https://progress.opensuse.org/issues/163622
@baierjan baierjan mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlpunk perlpunk perlpunk approved these changes

@kalikiana kalikiana kalikiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baierjan @perlpunk @kalikiana