openqa-investigate: Improve curl HTTP status handling #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
Jul 25, 2021
|
@perlpunk just a quick niptick: |
Issue: https://progress.opensuse.org/issues/95830 If a HTTP request doesn't return 200, we do not want to continue, and we want to know the actual URL and status. Because `investigate` is called with `|| do-something`, -e is not in effect, so we check each `runcurl` call explicitly.
perlpunk
force-pushed
the
curl-status-handling
branch
from
1f36da4
to
0abf20f
Compare
perlpunk
changed the title
oops. fixed in title and commit :) |
Martchus
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/95830
If a HTTP request doesn't return 200, we do not want to continue, and we want
to know the actual URL and status.
Because
investigateis called with|| do-something, -e is notin effect, so we check each
runcurlcall explicitly.I did the same for the
runjqcalls.