openqa-investigate: Fix handling of jobs without previous jobs #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: https://progress.opensuse.org/issues/95830 .last_good can be "not found", but also null when there are no previous jobs.
perlpunk
force-pushed
the
fix-job-without-previous
branch
from
763cc4a
to
96ff418
Compare
perlpunk
changed the title
okurz
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/95830
.last_good can be "not found", but also null when there are no previous
jobs.
(I simply missed that last_good_exists was never checked for "null")
The posted comment will now contain
No last good recorded, skipping regression investigation jobslike in other cases where no last good is found.