Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformer implementation of relevance task #216

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

Shreyanand
Copy link
Member

@Shreyanand Shreyanand commented Oct 12, 2022

This PR adds transformer implementation and distilbert base model for the relevance task. These notebooks will enable us to experiment with sparse models.

Reference Issues:
Closes #221
Addresses #184

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Shreyanand Shreyanand changed the title Add transformer implementation of relevance task [WIP] Add transformer implementation of relevance task Oct 12, 2022
Signed-off-by: Shreyanand <shanand@redhat.com>
@Shreyanand Shreyanand changed the title [WIP] Add transformer implementation of relevance task Add transformer implementation of relevance task Oct 26, 2022
Copy link
Member

@suppathak suppathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shreyanand ,
I am trying to run this notebook. I am encountering some minor bugs like "no module error" for sparsezoo, evaluate and datdaset. Is it possible to include them in the dependencies file? wdyt?

@Shreyanand
Copy link
Member Author

Hi @Shreyanand , I am trying to run this notebook. I am encountering some minor bugs like "no module error" for sparsezoo, evaluate and datdaset. Is it possible to include them in the dependencies file? wdyt?

Good observation, I tried adding those to dependency files but some of them will cause an error with the farm notebooks as those notebooks rely on older versions of these packages. We need overlays for this problem but it'll take a while so for our experiments we'd have to pip install them for the time being.

@suppathak
Copy link
Member

/lgtm

@Shreyanand
Copy link
Member Author

/approve

@sesheta
Copy link
Member

sesheta commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shreyanand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 14a1198 into os-climate:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create huggingface version of text classification relevance task
3 participants