Skip to content

Commit

Permalink
Added apt update tasks to everything using apt
Browse files Browse the repository at this point in the history
This change adds a specific update task to all tasks that all the
apt ansible module. This change was done to ensure that the cache
is updated as expected when instructed to do so. The reason that
the cache update is being removed from the grouping is because
there is an upstream bug that is effecting the process by which
the apt cache is updated when there is a package list to process
within the same task. The work around to make this function as
expected is to move the update into its own task without a package
list.

Upstream Ansible bug:
  - ansible/ansible-modules-core#1497

Change-Id: Ic06d89a76d772c12888b4bc4bbf147be58b0c150
Related-Bug: 1464771
  • Loading branch information
cloudnull committed Jun 16, 2015
1 parent ab526a5 commit 9ff1b3b
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 6 deletions.
14 changes: 12 additions & 2 deletions tasks/nova_compute_kvm_install.yml
Expand Up @@ -13,12 +13,22 @@
# See the License for the specific language governing permissions and
# limitations under the License.

- name: Update apt sources
apt:
update_cache: yes
cache_valid_time: 600
register: apt_update
until: apt_update|success
retries: 5
delay: 2
tags:
- nova-apt-packages
- nova-compute-kvm-apt-packages

- name: Install apt packages
apt:
pkg: "{{ item }}"
state: latest
update_cache: yes
cache_valid_time: 600
register: install_packages
until: install_packages|success
retries: 5
Expand Down
13 changes: 11 additions & 2 deletions tasks/nova_install.yml
Expand Up @@ -13,12 +13,21 @@
# See the License for the specific language governing permissions and
# limitations under the License.

- name: Update apt sources
apt:
update_cache: yes
cache_valid_time: 600
register: apt_update
until: apt_update|success
retries: 5
delay: 2
tags:
- nova-apt-packages

- name: Install apt packages
apt:
pkg: "{{ item }}"
state: latest
update_cache: yes
cache_valid_time: 600
register: install_packages
until: install_packages|success
retries: 5
Expand Down
15 changes: 13 additions & 2 deletions tasks/nova_spice_console_install.yml
Expand Up @@ -13,17 +13,28 @@
# See the License for the specific language governing permissions and
# limitations under the License.

- name: Update apt sources
apt:
update_cache: yes
cache_valid_time: 600
register: apt_update
until: apt_update|success
retries: 5
delay: 2
tags:
- nova-apt-packages
- nova-spice-apt-packages

- name: Install apt packages
apt:
pkg: "{{ item }}"
state: latest
update_cache: yes
cache_valid_time: 600
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items: nova_spice_apt_packages
tags:
- nova-apt-packages
- nova-spice-apt-packages

0 comments on commit 9ff1b3b

Please sign in to comment.