Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the include error for scope_guard.hpp #1563

Merged
merged 4 commits into from
May 2, 2024

Conversation

NadeemYaseen
Copy link
Contributor

The scope_guard.hpp directory was not in the include directory so added it in the include directory so that compiler can find it.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.49%. Comparing base (353a987) to head (a7fff02).

❗ Current head a7fff02 differs from pull request most recent head 135aa46. Consider uploading reports for the commit 135aa46 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   14.49%   14.49%           
=======================================
  Files         475      475           
  Lines       61664    61664           
  Branches    24803    24760   -43     
=======================================
  Hits         8937     8937           
+ Misses      51649    51644    -5     
- Partials     1078     1083    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravikiranchollangi ravikiranchollangi merged commit 8c4a70d into main May 2, 2024
2 checks passed
@ravikiranchollangi ravikiranchollangi deleted the scopeguradincludefix branch May 2, 2024 16:18
@ravikiranchollangi
Copy link
Contributor

Thanks @NadeemYaseen , the CI got stuck with status in this one. Hoping it's not a action version mismatch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants