Linting use before define in some cases

src/build/config.js

@@ -139,6 +139,33 @@ function generateServerConfiguration(cli, cfg) {
   });
 }
 
+/*
+ * Get a configuration value by path
+ */
+function getConfigPath(config, path, defaultValue) {
+  if ( typeof path === 'string' ) {
+    var result = null;
+    var ns = config;
+
+    const queue = path.split(/\./);
+    queue.forEach(function(k, i) {
+      if ( i >= queue.length - 1 ) {
+        result = ns[k];
+      } else {
+        ns = ns[k];
+      }
+    });
+
+    if ( typeof result === 'undefined' ) {
+      return defaultValue;
+    }
+
+    return result;
+  }
+
+  return config;
+}
+
 /*
  * Sets a config value
  */
@@ -300,33 +327,6 @@ function getConfiguration() {
   });
 }
 
-/*
- * Get a configuration value by path
- */
-function getConfigPath(config, path, defaultValue) {
-  if ( typeof path === 'string' ) {
-    var result = null;
-    var ns = config;
-
-    const queue = path.split(/\./);
-    queue.forEach(function(k, i) {
-      if ( i >= queue.length - 1 ) {
-        result = ns[k];
-      } else {
-        ns = ns[k];
-      }
-    });
-
-    if ( typeof result === 'undefined' ) {
-      return defaultValue;
-    }
-
-    return result;
-  }
-
-  return config;
-}
-
 ///////////////////////////////////////////////////////////////////////////////
 // TASKS
 ///////////////////////////////////////////////////////////////////////////////

src/build/generate.js

@@ -203,7 +203,7 @@ const TASKS = {
     });
 
     if ( (cfg.repositories || []).indexOf(repo) < 0 ) {
-      console.warn('The repository \'' + repo + '\' is not active.'['yellow']);
+      console.warn(String.color('The repository \'' + repo + '\' is not active.', 'yellow'));
     }
 
     return Promise.resolve();

src/build/manifest.js

@@ -71,6 +71,26 @@ function parsePreloads(iter) {
 // API
 ///////////////////////////////////////////////////////////////////////////////
 
+/*
+ * Checks if package is enabled
+ */
+function checkEnabledState(enabled, disabled, meta) {
+  const name = meta.path;
+  const shortName = meta.path.split('/')[1];
+
+  if ( String(meta.enabled) === 'false' ) {
+    if ( enabled.indexOf(shortName) !== -1 ) {
+      return true;
+    }
+    return enabled.indexOf(name) !== -1;
+  }
+
+  if ( disabled.indexOf(shortName) === -1 ) {
+    return true;
+  }
+  return disabled.indexOf(name) === -1;
+}
+
 /*
  * Get Package Metadata
  */
@@ -173,26 +193,6 @@ function generateClientManifest(target, manifest) {
   });
 }
 
-/*
- * Checks if package is enabled
- */
-function checkEnabledState(enabled, disabled, meta) {
-  const name = meta.path;
-  const shortName = meta.path.split('/')[1];
-
-  if ( String(meta.enabled) === 'false' ) {
-    if ( enabled.indexOf(shortName) !== -1 ) {
-      return true;
-    }
-    return enabled.indexOf(name) !== -1;
-  }
-
-  if ( disabled.indexOf(shortName) === -1 ) {
-    return true;
-  }
-  return disabled.indexOf(name) === -1;
-}
-
 ///////////////////////////////////////////////////////////////////////////////
 // API
 ///////////////////////////////////////////////////////////////////////////////

src/client/javascript/core/windowmanager.js

@@ -146,105 +146,6 @@
     var current = null;
     var newRect = {};
 
-    /**
-     * When mouse button is pressed
-     */
-    function onMouseDown(ev, action, win, mousePosition) {
-      OSjs.API.blurMenu();
-      ev.preventDefault();
-
-      if ( win._state.maximized ) {
-        return;
-      }
-
-      current = new BehaviourState(win, action, mousePosition);
-      newRect = {};
-
-      win._focus();
-
-      if ( action === 'move' ) {
-        current.$element.setAttribute('data-hint', 'moving');
-      } else {
-        current.calculateDirection();
-        current.$element.setAttribute('data-hint', 'resizing');
-
-        newRect = current.getRect();
-      }
-
-      win._emit('preop');
-
-      Utils.$bind(document, 'mousemove:movewindow', _onMouseMove, false);
-      Utils.$bind(document, 'mouseup:movewindowstop', _onMouseUp, false);
-
-      function _onMouseMove(ev, pos) {
-        if ( wm._mouselock ) {
-          onMouseMove(ev, action, win, pos);
-        }
-      }
-      function _onMouseUp(ev, pos) {
-        onMouseUp(ev, action, win, pos);
-        Utils.$unbind(document, 'mousemove:movewindow');
-        Utils.$unbind(document, 'mouseup:movewindowstop');
-      }
-    }
-
-    /**
-     * When mouse button is released
-     */
-    function onMouseUp(ev, action, win, mousePosition) {
-      if ( !current ) {
-        return;
-      }
-
-      if ( current.moved ) {
-        if ( action === 'move' ) {
-          win._onChange('move', true);
-          win._emit('moved', [win._position.x, win._position.y]);
-        } else if ( action === 'resize' ) {
-          win._onChange('resize', true);
-          win._emit('resized', [win._dimension.w, win._dimension.h]);
-        }
-      }
-
-      current.$element.setAttribute('data-hint', '');
-
-      win._emit('postop');
-
-      current = null;
-    }
-
-    /**
-     * When mouse is moved
-     */
-    function onMouseMove(ev, action, win, mousePosition) {
-      if ( !_WM.getMouseLocked() || !action || !current ) {
-        return;
-      }
-
-      var result;
-      var dx = mousePosition.x - current.startX;
-      var dy = mousePosition.y - current.startY;
-
-      if ( action === 'move' ) {
-        result = onWindowMove(ev, mousePosition, dx, dy);
-      } else {
-        result = onWindowResize(ev, mousePosition, dx, dy);
-      }
-
-      if ( result ) {
-        if ( result.left !== null && result.top !== null ) {
-          win._move(result.left, result.top);
-          win._emit('move', [result.left, result.top]);
-        }
-        if ( result.width !== null && result.height !== null ) {
-          win._resize(result.width, result.height, true);
-          win._emit('resize', [result.width, result.height]);
-        }
-      }
-
-      current.moved = true;
-    }
-
     /**
      * Resizing action
      */
@@ -371,6 +272,105 @@
       return {left: newLeft, top: newTop, width: newWidth, height: newHeight};
     }
 
+    /**
+     * When mouse button is released
+     */
+    function onMouseUp(ev, action, win, mousePosition) {
+      if ( !current ) {
+        return;
+      }
+
+      if ( current.moved ) {
+        if ( action === 'move' ) {
+          win._onChange('move', true);
+          win._emit('moved', [win._position.x, win._position.y]);
+        } else if ( action === 'resize' ) {
+          win._onChange('resize', true);
+          win._emit('resized', [win._dimension.w, win._dimension.h]);
+        }
+      }
+
+      current.$element.setAttribute('data-hint', '');
+
+      win._emit('postop');
+
+      current = null;
+    }
+
+    /**
+     * When mouse is moved
+     */
+    function onMouseMove(ev, action, win, mousePosition) {
+      if ( !_WM.getMouseLocked() || !action || !current ) {
+        return;
+      }
+
+      var result;
+      var dx = mousePosition.x - current.startX;
+      var dy = mousePosition.y - current.startY;
+
+      if ( action === 'move' ) {
+        result = onWindowMove(ev, mousePosition, dx, dy);
+      } else {
+        result = onWindowResize(ev, mousePosition, dx, dy);
+      }
+
+      if ( result ) {
+        if ( result.left !== null && result.top !== null ) {
+          win._move(result.left, result.top);
+          win._emit('move', [result.left, result.top]);
+        }
+        if ( result.width !== null && result.height !== null ) {
+          win._resize(result.width, result.height, true);
+          win._emit('resize', [result.width, result.height]);
+        }
+      }
+
+      current.moved = true;
+    }
+
+    /**
+     * When mouse button is pressed
+     */
+    function onMouseDown(ev, action, win, mousePosition) {
+      OSjs.API.blurMenu();
+      ev.preventDefault();
+
+      if ( win._state.maximized ) {
+        return;
+      }
+
+      current = new BehaviourState(win, action, mousePosition);
+      newRect = {};
+
+      win._focus();
+
+      if ( action === 'move' ) {
+        current.$element.setAttribute('data-hint', 'moving');
+      } else {
+        current.calculateDirection();
+        current.$element.setAttribute('data-hint', 'resizing');
+
+        newRect = current.getRect();
+      }
+
+      win._emit('preop');
+
+      function _onMouseMove(ev, pos) {
+        if ( wm._mouselock ) {
+          onMouseMove(ev, action, win, pos);
+        }
+      }
+      function _onMouseUp(ev, pos) {
+        onMouseUp(ev, action, win, pos);
+        Utils.$unbind(document, 'mousemove:movewindow');
+        Utils.$unbind(document, 'mouseup:movewindowstop');
+      }
+
+      Utils.$bind(document, 'mousemove:movewindow', _onMouseMove, false);
+      Utils.$bind(document, 'mouseup:movewindowstop', _onMouseUp, false);
+    }
+
     /**
      * Register a window
      */

src/client/javascript/gui.js

@@ -464,19 +464,6 @@
     var startX, startY, currentX, currentY;
     var dragging = false;
 
-    function _onMouseDown(ev, pos, touchDevice) {
-      ev.preventDefault();
-
-      startX = pos.x;
-      startY = pos.y;
-
-      onDown(ev, {x: startX, y: startY});
-      dragging = true;
-
-      Utils.$bind(window, 'mouseup:guidrag', _onMouseUp, false);
-      Utils.$bind(window, 'mousemove:guidrag', _onMouseMove, false);
-    }
-
     function _onMouseMove(ev, pos, touchDevice) {
       ev.preventDefault();
 
@@ -499,6 +486,19 @@
       Utils.$unbind(window, 'mousemove:guidrag');
     }
 
+    function _onMouseDown(ev, pos, touchDevice) {
+      ev.preventDefault();
+
+      startX = pos.x;
+      startY = pos.y;
+
+      onDown(ev, {x: startX, y: startY});
+      dragging = true;
+
+      Utils.$bind(window, 'mouseup:guidrag', _onMouseUp, false);
+      Utils.$bind(window, 'mousemove:guidrag', _onMouseMove, false);
+    }
+
     Utils.$bind(el, 'mousedown', _onMouseDown, false);
   };
 

src/client/javascript/utils/events.js

@@ -302,6 +302,7 @@
      * Creates touch gestures for emulating mouse input
      */
     function createGestureHandler(el, n, t, callback, useCapture) {
+      /*eslint no-use-before-define: "off"*/
       var started;
       var contextTimeout;
       var dblTimeout;