Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound contract not ready for splash screen #192

Open
ajmeese7 opened this issue Sep 10, 2022 · 1 comment
Open

Sound contract not ready for splash screen #192

ajmeese7 opened this issue Sep 10, 2022 · 1 comment
Labels
question Further information is requested

Comments

@ajmeese7
Copy link
Member

Whenever authentication is enabled, the sound contract is not initialized until after the user is authenticated, rendering it not possible to play a sound as part of the splash screen.

I know this issue isn't apparent in normal OS.js because there are no sounds on the splash, but I plan on changing this behavior on my fork so sound will work on the splash with or without authentication enabled and whether or not the user has a saved authentication cookie. Would you be interested in having this behavior ported over to OS.js?

If so, please let me know your thoughts about how you would like to see it done.

@ajmeese7 ajmeese7 added the question Further information is requested label Sep 10, 2022
@andersevenrud
Copy link
Member

Is it even possible to play a sound without initial user movement / interaction ?

Would you be interested in having this behavior ported over to OS.js?

If you have something you think is valuable, just open a PR. No need to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants