Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL styles #38

Open
andersevenrud opened this issue Dec 30, 2018 · 3 comments
Open

Add RTL styles #38

andersevenrud opened this issue Dec 30, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed implemented Has been implemented, but not necessarily finished

Comments

@andersevenrud
Copy link
Member

I had this in v2 and should be back-ported. Basically add an attribute to the root element that sets all text CSS styles to RTL.

@andersevenrud andersevenrud added the enhancement New feature or request label Dec 30, 2018
@andersevenrud andersevenrud self-assigned this Dec 30, 2018
andersevenrud added a commit that referenced this issue Jan 1, 2019
@andersevenrud
Copy link
Member Author

@BoFFire I've started work on this. I've implemented everything into the client, so now I just have to go over the theme(s) and make some corrections to margins etc 🙂

os js

@BoFFire
Copy link

BoFFire commented Jan 1, 2019

Oh nice work @andersevenrud \o/ We appreciate. Thank you !

andersevenrud added a commit that referenced this issue Jan 1, 2019
@andersevenrud
Copy link
Member Author

I've also updated @osjs/panels and @osjs/gui now, so this should now work pretty well. The only things missing are:

  • Icons with arrows needs to be swapped
  • ContextMenu needs to be optimized a bit (when it appears outside the right viewport it's a bit wonky)
  • Panes gui component resize event is inverted
  • Some very minor theme style stuff

The language is detect by the first segment of a locale, ex: en_EN will be looked up as en in this table:

https://github.com/os-js/osjs-client/blob/master/src/config.js#L168

This will set an attribute in the DOM which the CSS handles.

os js2

@andersevenrud andersevenrud added implemented Has been implemented, but not necessarily finished help wanted Extra attention is needed labels Jan 9, 2019
@andersevenrud andersevenrud added the good first issue Good for newcomers label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed implemented Has been implemented, but not necessarily finished
Projects
None yet
Development

No branches or pull requests

2 participants