Support serialization of url query parameters #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersevenrud
requested changes
Jul 26, 2022
src/utils/fetch.js
Outdated
Comment on lines
32
to
34
| // /* | ||
| // * Creates URL request path | ||
| // */ |
There was a problem hiding this comment.
Remove duplicate comment characters :)
There was a problem hiding this comment.
Oops! sorry for that.
src/utils/fetch.js
Outdated
| // */ | ||
| export const encodeQueryData = (data) => { | ||
| const replacer = (k, v)=>(v === undefined ? null : v); | ||
| const pairs = Object.entries(data).map(([key, val]) => { |
There was a problem hiding this comment.
Might be better to just filter out any null-ish values before doing the encoding. The backend doesn't really take null or undefined values anyway.
This way you can just do the following:
const pairs = Object.entries(data)
.filter(([, val]) => val !== null && val !== undefined)
.map(([key, val]) => {
const value = typeof val === 'object' ? JSON.stringify(val) : val;
return `${encodeURIComponent(key)}=${encodeURIComponent(value)}`;
});
|
@andersevenrud changes are done. As I said here, there were some issues about filtering client options passed. Do you want those to consider in this pull request? |
I'm not I sure I fully understand the issue. Edit: Let's split out everything into single PRs. It's much easier to manage this way :) |
andersevenrud
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.