Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Jest #24

Open
4 of 6 tasks
andersevenrud opened this issue Jul 31, 2022 · 1 comment
Open
4 of 6 tasks

Include Jest #24

andersevenrud opened this issue Jul 31, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andersevenrud
Copy link
Member

andersevenrud commented Jul 31, 2022

Testing suite belongs in this repo so that it can be locked globally instead of in the CI stages.

Makes it a heck of a lot easier to run tests locally as well, and out of the box.

Probably best to start with @^26 as it is today to ensure all tests run fine. Then upgrade to latest. This way packages with failing tests can just stage their update of this meta library.


Split out from os-js/osjs-client#185 (comment)

It's version locked in the CI because latest Jest seems to trigger some kind of edge case that leaves certain tests hanging. Haven't had time to look into it. Might actually just be a thing in the server codebase come to think of it.

Ideally it should be updated, and then be put into https://github.com/os-js/osjs-dev-meta instead of being in the CI stages.

Tasks

Stage 1

  1. Include Jest 26 as a dependency (make sure it's installed with node 16 or below!)
    1. Update README
  2. Upgrade dev-meta dependency on every package with tests, verify tests
    1. Remove the npm install -g jest from CI if verified

Stage 2

  1. Upgrade to latest Jest
  2. Upgrade dev-meta dependency on every package with tests, verify tests again and fix any errors

Related packages

@andersevenrud andersevenrud added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 31, 2022
@andersevenrud andersevenrud self-assigned this Jul 31, 2022
andersevenrud added a commit that referenced this issue Jul 31, 2022
@andersevenrud andersevenrud removed their assignment Jul 31, 2022
@andersevenrud
Copy link
Member Author

andersevenrud commented Jul 31, 2022

@ajmeese7 I went ahead and performed the Stage 1 changes here (along with releasing all of the recent server and client changes onto npm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant