Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD support? #25

Closed
GuyIncognito1986 opened this issue Jul 25, 2017 · 11 comments
Closed

FreeBSD support? #25

GuyIncognito1986 opened this issue Jul 25, 2017 · 11 comments

Comments

@GuyIncognito1986
Copy link

GuyIncognito1986 commented Jul 25, 2017

Hey currently the protoc-jar throws "protoc-jar: protoc version: 330, detected platform: freebsd/amd64
java.lang.RuntimeException: error occurred while compiling protobuf files: Unsupported platform: freebsd/amd64", would it be difficult to add in freebsd support? protoc does exist and has been ported to freebsd, I'd be willing to help with the testing or the coding for the support, it should be trivial considering linux and mac osx are already supported.

@os72
Copy link
Owner

os72 commented Aug 30, 2017

Sorry, I missed this.. Would you be able to provide binaries?

@GuyIncognito1986
Copy link
Author

Yeah sure, I have freebsd 11 x64 binaries compiled for libressl, it took a while to get the tool chain/build working though, is that good enough?

@GuyIncognito1986
Copy link
Author

Oh sorry just realised this isnt the grpc thread, yeah sure thing I can extract the protoc binaries for you, where would you like me to send them?

@os72
Copy link
Owner

os72 commented Aug 31, 2017

You could create a new folder for your platform, and send a PR. protoc should be built statically (./configure --disable-shared, make install-strip)

@os72
Copy link
Owner

os72 commented Sep 6, 2017

You can use PRs #27, #28 as examples

Could you also run java -jar protoc-jar-3.4.0.jar -pp and provide the output? Thanks

@nakul02
Copy link
Contributor

nakul02 commented Sep 6, 2017

Here are more detailed instructions to compile the protobuf compiler.

@GuyIncognito1986
Copy link
Author

GuyIncognito1986 commented Sep 6, 2017 via email

@kjopek
Copy link
Contributor

kjopek commented Sep 21, 2017

Was done in #31 for FreeBSD 11.1.

Edit:

java -jar protoc-jar-3.4.0.1-SNAPSHOT.jar -pp
------------------------------------------------------------------------
Detecting the operating system and CPU architecture
------------------------------------------------------------------------
os.detected.name: freebsd
os.detected.arch: x86_64
os.detected.version: 11.1
os.detected.version.major: 11
os.detected.version.minor: 1
os.detected.classifier: freebsd-x86_64

@os72
Copy link
Owner

os72 commented Sep 29, 2017

Released protoc-jar-3.4.0.1, protoc-jar-maven-plugin-3.4.0.1

@os72 os72 closed this as completed Sep 29, 2017
@iphydf
Copy link

iphydf commented Feb 5, 2018

https://mvnrepository.com/artifact/com.github.os72/protoc-jar/3.4.0.1 does not include FreeBSD binaries. Where are they?

@os72
Copy link
Owner

os72 commented Feb 5, 2018

Not all binaries are bundled (in order to keep the size manageable). But protoc-jar will automatically download:
http://central.maven.org/maven2/com/github/os72/protoc/
FreeBSD is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants