Separate proto3 and proto2 standard types. #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
--include_std_types
parameter doesn't work when compiling proto2 files containing standard types (e.g. protobuf's Options). The problem is thatdescriptor.proto
in proto3 is not backward compatible and thus proto2 compiler cannot compile it.In 062fd0c I'm proposing keep proto2 and proto3 proto files separately.
On the way, I added some patches to facilitate further development.
mvn test
always seem to succeed. When making changes, would nice ifmvn test
facilitated regression testing.include
and I realised that with the current setup one has to always remember to modify theassembly.xml
file.