Separate proto3 and proto2 standard types. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it's automatically packaged. And there has to be no boilerplate of configuring it in assembly.xml
|
Ack. Thank you. I see your solution with resources/include, will have a look. What else would you want to include? |
Proto3's descriptor.proto is not backward compatible.
jkukul
changed the title
|
@os72 I addded another commit and adjusted the PR description. |
|
Thank you. I've been busy, will look to merge soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
--include_std_typesparameter doesn't work when compiling proto2 files containing standard types (e.g. protobuf's Options). The problem is thatdescriptor.protoin proto3 is not backward compatible and thus proto2 compiler cannot compile it.In 062fd0c I'm proposing keep proto2 and proto3 proto files separately.
On the way, I added some patches to facilitate further development.
mvn testalways seem to succeed. When making changes, would nice ifmvn testfacilitated regression testing.includeand I realised that with the current setup one has to always remember to modify theassembly.xmlfile.