Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username and password recheck bypassed #658

Closed
peng-hui opened this issue May 26, 2020 · 0 comments
Closed

Username and password recheck bypassed #658

peng-hui opened this issue May 26, 2020 · 0 comments

Comments

@peng-hui
Copy link

Hi,

I just find that, in many places of oscommerce v2.3.4.1, the username and password recheck during registration and other processes can be bypassed easily through the magic string in loose comparison, for example "0e11111" == "0e22222" returns Bool(True). If the user sets the username or password to such magic strings, the recheck process using loose comparison (==) does not work at all.
Affected code locations

and some other files in catalog/password_reset.php, catalog/create_account.php and catalog/ext/modules/content/account/set_password.php
ruden added a commit to ruden/vanilla-oscommerce that referenced this issue Aug 29, 2020
@ruden
strict verification osCommerce#658
b258880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peng-hui