Sanitize query strings #1639
Merged
Sanitize query strings #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary so we can sanitize/encode inputs.
Use http::build_query instead of inline urlencode
protich
force-pushed
the
issue/query-string
branch
from
efeeee2
to
f0b18da
Compare
greezybacon
added a commit
that referenced
this pull request
Dec 30, 2014
Sanitize query strings Reviewed-By: Jared Hancock <jared@osticket.com>
| $pageNav->setURL('pages.php',$qstr.'&sort='.urlencode($_REQUEST['sort']).'&order='.urlencode($_REQUEST['order'])); | ||
| //Ok..lets roll...create the actual query | ||
| $qstr.='&order='.($order=='DESC'?'ASC':'DESC'); | ||
| $qstr = '&'. Http::build_query($qs); |
There was a problem hiding this comment.
This just looks wrong. $qs is now an empty array, and why should $qstr start with &? It's used below directly following the ? in a query string.
There was a problem hiding this comment.
I agree it looks wrong -- basically we don't have query strings to collect. $qstr starts with & for consistency reasons -- in some pages e.g include/staff/tickets.inc.php it's used at the end as opposed to directly following ?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses potential XSS exploit due to incorrect handling of user inputs used on query strings.