Issue: Getting Agent/User Name #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the Audit Plugin in a scenario that if we could not retrieve the staff or user during checks, the default else statement was $object->getUserId(). In the event that the object did not have that method, it resulted in a fatal error.
This commit fixes an issue we had with the audit plugin assuming that any time the config table is being updated, it is by a signed in Agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Audit Plugin in a scenario that if we could not retrieve the staff or user during checks, the default else statement was $object->getUserId(). In the event that the object did not have that method, for example, when running the cron job, the $object is ConfigItem, it resulted in a fatal error.
Additionally, it adds a commit that fixes an issue we had with the audit plugin assuming that any time the config table is being updated, it is by a signed in Agent.