Issue: Unlinking From Child Ticket

Make sure we account for unlinking within a ticket using an AJAX call.
osTicket · Sep 25, 2019 · c76cb21 · c76cb21
1 parent a0a58e4
commit c76cb21
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/include/ajax.tickets.php b/include/ajax.tickets.php
@@ -379,7 +379,13 @@ function updateMerge($ticket_id) {
         $info = array();
         $errors = array();
 
-        if ($_POST['tids']) {
+        if ($_POST['dtids']) {
+            foreach($_POST['dtids'] as $key => $value) {
+                if (is_numeric($key) && $ticket = Ticket::lookup($value))
+                    $ticket->unlink();
+            }
+            return true;
+        } elseif ($_POST['tids']) {
             if ($parent = Ticket::merge($_POST))
                 Http::response(201, 'Successfully managed');
             else

diff --git a/include/class.ticket.php b/include/class.ticket.php
@@ -2419,7 +2419,7 @@ function unlink() {
                 $child = Ticket::lookup($child[0]);
                 $child->unlinkChild($parent);
             }
-        } else
+        } elseif ($child)
             $child->unlinkChild($parent);
 
         if (count(Ticket::getChildTickets($pid)) == 0) {