1.11 Should Support PHP 7.1

[greezybacon]

This is an effort to fix all the warnings and crashes running osTicket on PHP 7.1

[JediKev]

🙏🏻🙏🏻🙏🏻

[husseinsheikh]

where is the download button for this pull?

[ntozier]

add .patch to the end of the url for a patch file.
Or .diff to the end of the url for a diff file.

If you are not familiar with .patch or .diff files then I recommend reading this:
https://www.thegeekstuff.com/2014/12/patch-command-examples
If this doesn't make sense there is a lot of examples on Google.

Or lastly you can click on the files changed tab and make the changes manually.

[Ketrel]

Is this still needed for the develop-next branch as of the current state at the 2fd4a42 commit?

[JediKev]

@Ketrel

It has not been merged so ya.

Cheers.

[Ketrel]

@JediKev

Just wanted to make sure since it no longer merges clean. I was looking through the diff and it looks like some of the blocks it would remove have changed entirely or have new lines, so I wasn't sure if it was still applicable at all.

[JediKev]

@Ketrel

Lol yea reason why we haven’t merged it yet as it needs to be finalized. Just go through and fix the conflicts for now. Be careful not to remove anything (especially class.filter.php this one gave me a ton of issues).

Cheers.

[GrahamKendall]

Hi All,

In my naivety with using Github, does anyone have available a zip file or similar with the ammended 19 files in?

Many Thanks,
Graham

[JediKev]

@GrahamKendall

Nope, for that you'll have to view each file in the Files tab, and download each one individually. (Github doesn't give you a download of the full pull request, mostly likely because it's way faster and easier to apply a patch or to just pull the changes to your own clone/fork)

The easiest way to get these changes is to tack .patch to the end of the pull URL (https://github.com/osTicket/osTicket/pull/4344.patch), get a patch file, and apply that patch to your clone/fork of the repo.

Cheers.

[t-oster]

Well @greezybacon @protich , what is the best way to help? Should I send a Pull request based on this pull request or how to proceed? I have the feeling, that you are spammed with Issues and Pull requests, so I want to help in the most efficient way.
I am planning to fix all PHP7.1+ issues and then add a few signals/hooks for better plugin support.

[GrahamKendall]

Hi All, yesterday morning I deployed 1.11 after commit 13f2f4a and that seems to have fixed out New Message Alerting.

We did have to rebuild the criteria for a custom queue page.

It also seems we have lost the "save" button from editing existing organisation notes, but I'll post that separately.

Very Many Thanks,
Graham