Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Signals to allow plugins to add headers #5348

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

AdamDempsey
Copy link

Added two new signals so plugins can add custom headers to client + staff pages.

(Excuse the multiple commits + reverts, first pull request!)

@AdamDempsey AdamDempsey changed the title [Feature Request] Add Signals to allow plugins to add headers eg custom javascript [Feature Request] Add Signals to allow plugins to add headers Jan 24, 2020
@JediKev JediKev added the review label Jan 30, 2020
@estebandelaf
Copy link

I have the same requirement. I solved using another approach.

But the idea is having the functionality in the osticket core files.

My vote is for this approach with signals.

In my case I use a new method in plugins, more info in: https://forum.osticket.com/d/98352-use-a-plugin-to-add-javascript-code-to-head-tag-in-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants