Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginSupport: Add more Signals with documentation #5693

Closed
wants to merge 1 commit into from

Conversation

t-oster
Copy link
Contributor

@t-oster t-oster commented Nov 12, 2020

This is a follow up of #4676

I added a few signals I need for my own plugins and added also some documentation in the signal class as comments for the constant signal-strings.

If you consider merging, please let me know, I am willing to add documentation for all other existing signal calls in order to make plugin development easier for future developers.

@t-oster
Copy link
Contributor Author

t-oster commented Nov 18, 2020

Well I still suggest you document the signals with constants like in this PR.
However I managed to work around all the missing singals with a plugin like https://github.com/clonemeagain/attachment_preview which basically captures the whole HTML before sending to the browser and then provides an interface for plugins to mess with it. This way I can hijack any HTML element via plugin.

Thus I close this PR.
However If you feel like adding more Signal documentation or even include a DOM-Manipulation Signal, feel free to contact me.

@t-oster t-oster closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant