Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Plugin Dependencies #6472

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

PHP Plugin Dependencies #6472

wants to merge 3 commits into from

Conversation

ntozier
Copy link
Contributor

@ntozier ntozier commented Feb 20, 2023

This PR:

  • requires all plugins include PHP dependencies in their plugin.php in a comma separated format in 'phpDependency '
    example: /include/plugins/pluginName/plugin.php
    circa line 16: after map closes, insert a new line.

'phpDependency' => 'ldapl',
or
'phpDependency' => 'ldapl,dremel,jedi',

  • osTicket will check to make sure the PHP dependency is enabled. If not, will display an error message with the missing dependency name when you go to configure the plugin.
  • Also logs the error to osTicket logs.

@ntozier
Update class.plugin.php
7fd78b1 
adds function getPHPDependency()
@ntozier
Plugin Dependencies
06a7fd1 
Checks to ensure that any require PHP dependencies are met as indicated in the plugins plugin.php.
Displays an error if they are not, and logs it to osTicket Error logs.
@ntozier
Update plugin.inc.php
3ba0c32 
minor code formatting changes.
@ntozier ntozier mentioned this pull request Feb 20, 2023
Open
@ntozier
Copy link
Contributor Author

ntozier commented Feb 20, 2023

I made a PR for auth-ldap
osTicket/osTicket-plugins#266
I will make PRs for the rest of the plugins once/if this is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ntozier